[WIP] Add RDataSource for TTree #17895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
4 times, most recently
from
aa4ea82 to
ffce5d4
Compare
|
|
Test Results 17 files 17 suites 4d 12h 35m 47s ⏱️ For more details on these failures, see this check. Results for commit 409d22f. ♻️ This comment has been updated with latest results. |
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
from
ffce5d4 to
be68db1
Compare
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
from
be68db1 to
6095fe3
Compare
This was referenced Mar 6, 2025
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
from
6095fe3 to
ee66417
Compare
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
2 times, most recently
from
b67ad02 to
2336551
Compare
This was referenced Mar 18, 2025
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
3 times, most recently
from
d17de72 to
392845e
Compare
vepadulano
requested review from
bellenot,
martamaja10 and
pcanal
as code owners
hageboeck
reviewed
Mar 19, 2025
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
2 times, most recently
from
5995528 to
186dbf8
Compare
hageboeck
approved these changes
Mar 27, 2025
A new RDataSource derived class is implemented for TTree data processing. The class follows almost entirely the same approach for processing of other data sources, with the exception of the MT case which still needs to be partially handled externally by TTreeProcessorMT. Nonetheless, the class and its API can be used throughout the RDF codebase to centralise all TTree-related usage and processing. While implementing the class, a few missing features or limitations of RDataSource were found which needed API extensions. For the moment, all the API extensions of RDataSource are private and it will be later decided whether to make them public or not.
The rest of the RDF codebase is adapted to use the new TTree data source. All the previous usage of raw TTree classes or API is now delegated to the RDataSource. With this commit, there are no more ways to create an RDataFrame processing a TTree without an RDataSource.
Shows the usual errors on Windows that a file cannot be removed, even though nothing is using it.
vepadulano
force-pushed
the
rdf-ttree-datasource
branch
from
186dbf8 to
409d22f
Compare
martamaja10
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are working on my machine with these changes, so I want to start testing on all platforms. Changes will be later split in multiple commits/PRs.